Skip to content

feat: add escrow immutability flow#29

Closed
dev-jodee wants to merge 7 commits intofix/a26sfr3-audit-remediationsfrom
fix/a26sfr3-immutability-split
Closed

feat: add escrow immutability flow#29
dev-jodee wants to merge 7 commits intofix/a26sfr3-audit-remediationsfrom
fix/a26sfr3-immutability-split

Conversation

@dev-jodee
Copy link
Collaborator

Summary

  • add escrow-level mutability flag and SetImmutable instruction/event
  • enforce immutable escrow for deposit and mutable-only guards for config mutation instructions
  • regenerate IDL/client artifacts and update web UI with Set Immutable
  • add and adjust integration tests for mutability/immutability behavior

Validation

  • just unit-test
  • just integration-test
  • pnpm --filter @solana/escrow-program-client build
  • pnpm --filter @solana/escrow-program-web typecheck

@dev-jodee dev-jodee requested a review from amilz March 23, 2026 17:13
Copy link
Collaborator

@amilz amilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • could add deposit/withdraw still works when immutable test
  • just check u8 vs bool field type is how you want it

@dev-jodee dev-jodee force-pushed the fix/a26sfr3-immutability-split branch from 9e377d0 to bb735c1 Compare March 23, 2026 17:44
dev-jodee and others added 6 commits March 23, 2026 13:47
Adds a full E2E test suite covering all 10 instruction panels, client-side
validation, and UI components against the live devnet app. Also fixes Withdraw
to auto-detect arbiter and hook extensions from the escrow's extensions PDA,
automatically appending them as remaining accounts so the UI works without any
extra form fields.

Co-authored-by: Jo D <dev-jodee@users.noreply.github.com>
Co-authored-by: Jo D <dev-jodee@users.noreply.github.com>
@dev-jodee dev-jodee force-pushed the fix/a26sfr3-immutability-split branch from bb735c1 to b223c64 Compare March 23, 2026 18:14
Restore #[cfg(test)] on the set_immutable integration test module to satisfy clippy in non-test targets.\n\nAlso keep rustfmt import/module ordering updates produced by formatting.
@dev-jodee
Copy link
Collaborator Author

Superseded by branch fix/a26sfr3-immutability-only, rebuilt from fix/a26sfr3-audit-remediations with only immutability commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants