feat: add escrow immutability flow#29
Closed
dev-jodee wants to merge 7 commits intofix/a26sfr3-audit-remediationsfrom
Closed
feat: add escrow immutability flow#29dev-jodee wants to merge 7 commits intofix/a26sfr3-audit-remediationsfrom
dev-jodee wants to merge 7 commits intofix/a26sfr3-audit-remediationsfrom
Conversation
amilz
approved these changes
Mar 23, 2026
Collaborator
amilz
left a comment
There was a problem hiding this comment.
- could add
deposit/withdraw still works when immutabletest - just check u8 vs bool field type is how you want it
9e377d0 to
bb735c1
Compare
Adds a full E2E test suite covering all 10 instruction panels, client-side validation, and UI components against the live devnet app. Also fixes Withdraw to auto-detect arbiter and hook extensions from the escrow's extensions PDA, automatically appending them as remaining accounts so the UI works without any extra form fields. Co-authored-by: Jo D <dev-jodee@users.noreply.github.com>
Co-authored-by: Jo D <dev-jodee@users.noreply.github.com>
bb735c1 to
b223c64
Compare
Restore #[cfg(test)] on the set_immutable integration test module to satisfy clippy in non-test targets.\n\nAlso keep rustfmt import/module ordering updates produced by formatting.
Collaborator
Author
|
Superseded by branch fix/a26sfr3-immutability-only, rebuilt from fix/a26sfr3-audit-remediations with only immutability commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation