Cantralize PatternsOperator config#584
Conversation
|
Hi @sector2000. Thanks for your PR. I'm waiting for a validatedpatterns member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
| set -e -o pipefail | ||
|
|
||
| CATALOGSOURCE="test-pattern-operator" | ||
| CATALOGSOURCE="test-patterns-operator" |
There was a problem hiding this comment.
This breaks my local testing, I have not looked into why (beyond the catalog not being found when launching the script). Reverting this lines fixes it for me. Can we change this in a separate PR maybe?
There was a problem hiding this comment.
I have reverted it. It's not really important. We don't need to change it in another PR.
|
/ok-to-test |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaldessari, sector2000 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 0e8fcd5
into
validatedpatterns:main
2 participants
Type
GitOpsConfigrenamed toPatternsOperatorConfigfor better clarity and to avoid confusion withPattern.Spec.GitOpsConfigThe
PatternsOperatorConfigis now fetched only once during reconciliation and passed to functions when needed