Skip to content

remove track_caller sentence#13267

Open
ShahakShama wants to merge 1 commit intoshahak/style-guide-remove-reexportsfrom
shahak/style-guide-remove-track-caller
Open

remove track_caller sentence#13267
ShahakShama wants to merge 1 commit intoshahak/style-guide-remove-reexportsfrom
shahak/style-guide-remove-track-caller

Conversation

@ShahakShama
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama commented Mar 15, 2026

Note

Low Risk
Low risk documentation-only change that removes a single testing recommendation; no code or behavior changes.

Overview
Removes the #[track_caller] recommendation from the Testing section in style.md, leaving the remaining guidance on writing debuggable assertions and structuring tests unchanged.

Written by Cursor Bugbot for commit dcc3953. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

ShahakShama commented Mar 15, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-track-caller branch from 5b2b972 to 3c533d0 Compare March 15, 2026 14:58
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from e18dbad to 16db7bb Compare March 15, 2026 14:58
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 16db7bb to 6cd6c43 Compare March 16, 2026 07:38
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-track-caller branch from 3c533d0 to 3919551 Compare March 16, 2026 07:38
Copy link
Copy Markdown
Contributor

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stavbe made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on ShahakShama).


style.md line 69 at r1 (raw file):

-   Resolving merge conflicts: AI tends sometimes to just pick our changes without thinking about it.

## Testing

Don't we want to put here the naming convention for tests?

Copy link
Copy Markdown
Collaborator Author

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Stavbe).


style.md line 69 at r1 (raw file):

Previously, Stavbe wrote…

Don't we want to put here the naming convention for tests?

Yes. Later PR in this stack :)

Copy link
Copy Markdown
Collaborator Author

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Stavbe).


style.md line 69 at r1 (raw file):

Previously, ShahakShama wrote…

Yes. Later PR in this stack :)

#13276

Copy link
Copy Markdown
Contributor

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stavbe reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-track-caller branch from 3919551 to 4f1503e Compare March 26, 2026 07:20
@ShahakShama ShahakShama force-pushed the shahak/style-guide-remove-reexports branch from 6cd6c43 to 21ed7cb Compare March 26, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants