Skip to content

add section on test names#13276

Open
ShahakShama wants to merge 1 commit intoshahak/style-guide-short-unit-test-recommendationfrom
shahak/style-guide-test-names
Open

add section on test names#13276
ShahakShama wants to merge 1 commit intoshahak/style-guide-short-unit-test-recommendationfrom
shahak/style-guide-test-names

Conversation

@ShahakShama
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama commented Mar 15, 2026

Note

Low Risk
Documentation-only change with no impact on runtime behavior or build/test execution.

Overview
Adds a new Test Names subsection to style.md under Testing that standardizes unit test naming: tests should use a test_ prefix and can be long/descriptive to clearly distinguish tests from helper functions.

Written by Cursor Bugbot for commit 0448af8. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

ShahakShama commented Mar 15, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ShahakShama ShahakShama force-pushed the shahak/style-guide-short-unit-test-recommendation branch from 85d3c4b to 2217ad7 Compare March 16, 2026 07:38
@ShahakShama ShahakShama force-pushed the shahak/style-guide-test-names branch from a97093c to 01a819e Compare March 16, 2026 07:38
Copy link
Copy Markdown
Contributor

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stavbe reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

@ShahakShama ShahakShama force-pushed the shahak/style-guide-test-names branch from 01a819e to 8e233b9 Compare March 26, 2026 07:20
@ShahakShama ShahakShama force-pushed the shahak/style-guide-short-unit-test-recommendation branch from 2217ad7 to 41db94c Compare March 26, 2026 07:20
@ShahakShama ShahakShama force-pushed the shahak/style-guide-test-names branch from 8e233b9 to beca173 Compare March 26, 2026 07:27
@ShahakShama ShahakShama force-pushed the shahak/style-guide-short-unit-test-recommendation branch 2 times, most recently from 7caf370 to 70041dd Compare March 26, 2026 07:44
@ShahakShama ShahakShama force-pushed the shahak/style-guide-test-names branch from beca173 to bb84c16 Compare March 26, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants