Skip to content

add section on expect vs allow#13626

Open
ShahakShama wants to merge 1 commit intoshahak/delete_combinators_sectionfrom
shahak/style-guide-expect-vs-allow
Open

add section on expect vs allow#13626
ShahakShama wants to merge 1 commit intoshahak/delete_combinators_sectionfrom
shahak/style-guide-expect-vs-allow

Conversation

@ShahakShama
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama commented Mar 31, 2026

Note

Low Risk
Low risk documentation-only change; no runtime behavior or APIs are modified.

Overview
Adds a new style.md guideline section recommending #[expect(...)] over #[allow(...)] for lint suppression, with a short rationale and example showing how #[expect] prevents stale suppressions.

Written by Cursor Bugbot for commit d1d0981. This will update automatically on new commits. Configure here.

@ShahakShama ShahakShama requested a review from Stavbe March 31, 2026 14:20
@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

ShahakShama commented Mar 31, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants