apollo_infra: create component clients with channel#13565
Open
ArniStarkware wants to merge 1 commit intoarni/config_manager/add_sender_channel_to_config_manager_runnnerfrom
Open
Conversation
|
This change is |
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ArniStarkware
force-pushed
the
arni/infra/create_component_clients_with_channel
branch
from
88af4d1 to
86f5075
Compare
ArniStarkware
force-pushed
the
arni/config_manager/add_sender_channel_to_config_manager_runnner
branch
from
b4eb1e5 to
65e2e26
Compare
ArniStarkware
force-pushed
the
arni/infra/create_component_clients_with_channel
branch
from
86f5075 to
2b69490
Compare
ArniStarkware
force-pushed
the
arni/infra/create_component_clients_with_channel
branch
from
2b69490 to
b5d24a5
Compare
ArniStarkware
force-pushed
the
arni/infra/create_component_clients_with_channel
branch
from
b5d24a5 to
cb2b077
Compare
ArniStarkware
force-pushed
the
arni/config_manager/add_sender_channel_to_config_manager_runnner
branch
from
4973804 to
f157278
Compare
ArniStarkware
force-pushed
the
arni/config_manager/add_sender_channel_to_config_manager_runnner
branch
from
f157278 to
1a4208c
Compare
ArniStarkware
force-pushed
the
arni/infra/create_component_clients_with_channel
branch
from
cb2b077 to
122d3f1
Compare
ArniStarkware
changed the base branch from
arni/config_manager/add_sender_channel_to_config_manager_runnner
to
graphite-base/13565
ArniStarkware
force-pushed
the
graphite-base/13565
branch
from
1a4208c to
ac8af19
Compare
ArniStarkware
force-pushed
the
arni/infra/create_component_clients_with_channel
branch
from
122d3f1 to
77f78db
Compare
ArniStarkware
changed the base branch from
graphite-base/13565
to
arni/config_manager/add_sender_channel_to_config_manager_runnner
ArniStarkware
force-pushed
the
arni/infra/create_component_clients_with_channel
branch
from
77f78db to
59a5b53
Compare
ArniStarkware
force-pushed
the
arni/config_manager/add_sender_channel_to_config_manager_runnner
branch
from
ac8af19 to
65bfb02
Compare
ArniStarkware
force-pushed
the
arni/infra/create_component_clients_with_channel
branch
3 times, most recently
from
8f4c3f5 to
b6da9bc
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ArniStarkware
force-pushed
the
arni/config_manager/add_sender_channel_to_config_manager_runnner
branch
from
65bfb02 to
e435fb5
Compare
ArniStarkware
force-pushed
the
arni/infra/create_component_clients_with_channel
branch
from
b6da9bc to
ab0ab24
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
ArniStarkware
force-pushed
the
arni/infra/create_component_clients_with_channel
branch
from
ab0ab24 to
e4b9b80
Compare
ArniStarkware
commented
Mar 31, 2026
Contributor
Author
ArniStarkware
left a comment
ArniStarkware
left a comment
There was a problem hiding this comment.
@ArniStarkware resolved 1 discussion.
Reviewable status: 0 of 10 files reviewed, all discussions resolved.
ArniStarkware
force-pushed
the
arni/infra/create_component_clients_with_channel
branch
from
e4b9b80 to
6634c16
Compare
ArniStarkware
force-pushed
the
arni/config_manager/add_sender_channel_to_config_manager_runnner
branch
from
e435fb5 to
11ac8e9
Compare
ArniStarkware
requested review from
Itay-Tsabary-Starkware and
nadin-Starkware
and removed request for
Itay-Tsabary-Starkware
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Medium risk because it introduces new infra/client abstractions and config accessors that
expectmissing fields, which could cause runtime panics if dynamic config isn’t populated correctly.Overview
Enables channel-backed component clients by adding
ComponentChannelClientplus aLocalComponentChannelClientthat reads the latest value from atokio::sync::watchchannel (with basic unit tests).Adds a new synchronous
ConfigManagerChannelClientinapollo_config_manager_typesthat exposes per-component dynamic config getters by reading fields fromNodeDynamicConfig(generated via apastemacro), and wires in the newpastedependency.Written by Cursor Bugbot for commit 6634c16. This will update automatically on new commits. Configure here.