apollo_infra: refactor client struct to be an enum

[ArniStarkware]

Note

Medium Risk
Medium risk because this changes the core Client type and construction/retrieval logic used across node components, which could break wiring or disable clients if match arms are missed.

Overview
Refactors the component Client<Request, Response> from a struct holding optional local/remote clients into an enum with explicit Local, Remote, and Disabled variants, removing the Client::new constructor and the “both set” panic.

Updates client creation and access helpers in apollo_node to pattern-match on the new enum: create_client! now returns a concrete Client variant (including Client::Disabled), and get_shared_client! builds an Arc from the active variant or returns None when disabled.

^{Written by Cursor Bugbot for commit 2b86e25. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[ArniStarkware]

• apollo_config_manager_types: remove deprecated config manager RPC infrastructure #13645
• apollo_config_manager,apollo_node: remove ConfigManager #13644
• apollo_config_manager: remove config manager client from runner #13643
• apollo_node: replace config manager client with channel client #13581
• apollo_http_server: remove use of deprecated config manager shared client #13567
• apollo_http_server: add client with channel to http server #13566
• apollo_node: wire config manager dynamic config channel #13568
• apollo_infra: create component clients with channel #13565
• apollo_config_manager: add sender channel to the config manager runner #13477
• apollo_infra: refactor client struct to be an enum #13570 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArniStarkware]

crates/apollo_node/src/clients.rs line 323 at r1 (raw file):

/// // LocalBatcherClient and RemoteBatcherClient have new methods that accept a channel and config,
/// // respectively.
/// let batcher_client: Option<Client<BatcherRequest, BatcherResponse>> = create_client!(

This is a typo from before this PR.

Suggestion:

/// let batcher_client: Client<BatcherRequest, BatcherResponse> = create_client!(

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[nadin-Starkware]

@nadin-Starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArniStarkware and Itay-Tsabary-Starkware).

---

crates/apollo_infra/src/component_client/definitions.rs line 32 at r2 (raw file):

    Local(LocalComponentClient<Request, Response>),
    Remote(RemoteComponentClient<Request, Response>),
    None,

Please rename Disabled for clarity and to avoid Option::None shadowing

Code quote:

None

[ArniStarkware]

crates/apollo_infra/src/component_client/definitions.rs line 32 at r2 (raw file):

Previously, nadin-Starkware (Nadin Jbara) wrote…

Please rename Disabled for clarity and to avoid Option::None shadowing

Done. Removed this option. Looks like it is never used. If it is needed, we will add it.

[ArniStarkware]

@ArniStarkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on Itay-Tsabary-Starkware and nadin-Starkware).

---

crates/apollo_infra/src/component_client/definitions.rs line 32 at r2 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Done. Removed this option. Looks like it is never used. If it is needed, we will add it.

Returned the Disabled option (it is very much used).

[nadin-Starkware]

@nadin-Starkware reviewed 2 files and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Itay-Tsabary-Starkware).