apollo_config_manager_types: remove deprecated config manager RPC infrastructure#13645
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6dd415e to
d02a878
Compare
aaf8c3f to
3ce9c16
Compare
d02a878 to
ed9edf6
Compare
3ce9c16 to
b7855ff
Compare
5ee5b32 to
fd423a7
Compare
84565df to
844a53b
Compare
fd423a7 to
be6dc48
Compare
844a53b to
b401eae
Compare
be6dc48 to
80ebd9e
Compare
|
Artifacts upload workflows: |
80ebd9e to
57ed974
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 57ed974. Configure here.
| use apollo_state_sync_config::config::StateSyncDynamicConfig; | ||
| use async_trait::async_trait; | ||
| use serde::{Deserialize, Serialize}; | ||
| use strum::{AsRefStr, EnumDiscriminants, EnumIter, IntoStaticStr, VariantNames}; |
There was a problem hiding this comment.
Orphaned module config_manager_types is now dead code
Low Severity
The removal of ConfigManagerResponse (which was the only consumer of ConfigManagerResult) leaves the entire config_manager_types sub-module as dead code. The file config_manager_types.rs only defines pub type ConfigManagerResult<T> = Result<T, ConfigManagerError>, which is no longer referenced anywhere in the codebase. This module and its re-export in lib.rs could have been cleaned up as part of this deprecation removal.
Reviewed by Cursor Bugbot for commit 57ed974. Configure here.



Note
Medium Risk
Removes the config manager’s RPC request/response layer and its infra metrics wiring from the node and dashboards, which could break deployments or monitoring if any remaining code/config still expects those endpoints/metrics.
Overview
This PR removes the deprecated
apollo_config_manager_typesRPC infrastructure (request/response enums, async client trait, metrics label generation) and leaves only the channel-basedConfigManagerChannelClientaccessors overNodeDynamicConfig.It also drops config-manager infra metrics exposure:
apollo_config_managerno longer defines/registers infra client/server metrics, and the Grafana dashboard/alerts plus dashboard code references for config-manager infra panels/connection alerts are removed.Finally,
apollo_nodeis updated to stop depending onapollo_config_manager_typesand to remove config-manager client/channel creation and accessors fromSequencerNodeClients/SequencerNodeCommunication, with corresponding Cargo.lock dependency cleanup.Reviewed by Cursor Bugbot for commit 57ed974. Bugbot is set up for automated code reviews on this repo. Configure here.