Skip to content

apollo_config_manager_types: remove deprecated config manager RPC infrastructure#13645

Open
ArniStarkware wants to merge 1 commit intoarni/config_manager/remove_config_managerfrom
arni/config_manager_types/remove_rpc_infrastructure
Open

apollo_config_manager_types: remove deprecated config manager RPC infrastructure#13645
ArniStarkware wants to merge 1 commit intoarni/config_manager/remove_config_managerfrom
arni/config_manager_types/remove_rpc_infrastructure

Conversation

@ArniStarkware
Copy link
Copy Markdown
Contributor

@ArniStarkware ArniStarkware commented Apr 2, 2026

Note

Medium Risk
Removes the config manager’s RPC request/response layer and its infra metrics wiring from the node and dashboards, which could break deployments or monitoring if any remaining code/config still expects those endpoints/metrics.

Overview
This PR removes the deprecated apollo_config_manager_types RPC infrastructure (request/response enums, async client trait, metrics label generation) and leaves only the channel-based ConfigManagerChannelClient accessors over NodeDynamicConfig.

It also drops config-manager infra metrics exposure: apollo_config_manager no longer defines/registers infra client/server metrics, and the Grafana dashboard/alerts plus dashboard code references for config-manager infra panels/connection alerts are removed.

Finally, apollo_node is updated to stop depending on apollo_config_manager_types and to remove config-manager client/channel creation and accessors from SequencerNodeClients/SequencerNodeCommunication, with corresponding Cargo.lock dependency cleanup.

Reviewed by Cursor Bugbot for commit 57ed974. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@ArniStarkware ArniStarkware force-pushed the arni/config_manager_types/remove_rpc_infrastructure branch from 6dd415e to d02a878 Compare April 2, 2026 19:28
@ArniStarkware ArniStarkware force-pushed the arni/config_manager/remove_config_manager branch from aaf8c3f to 3ce9c16 Compare April 2, 2026 19:28
@ArniStarkware ArniStarkware force-pushed the arni/config_manager_types/remove_rpc_infrastructure branch from d02a878 to ed9edf6 Compare April 2, 2026 19:41
@ArniStarkware ArniStarkware force-pushed the arni/config_manager/remove_config_manager branch from 3ce9c16 to b7855ff Compare April 2, 2026 19:41
@ArniStarkware ArniStarkware force-pushed the arni/config_manager_types/remove_rpc_infrastructure branch 2 times, most recently from 5ee5b32 to fd423a7 Compare April 3, 2026 06:41
@ArniStarkware ArniStarkware force-pushed the arni/config_manager/remove_config_manager branch 2 times, most recently from 84565df to 844a53b Compare April 3, 2026 07:18
@ArniStarkware ArniStarkware force-pushed the arni/config_manager_types/remove_rpc_infrastructure branch from fd423a7 to be6dc48 Compare April 3, 2026 07:18
@ArniStarkware ArniStarkware marked this pull request as ready for review April 5, 2026 04:30
@ArniStarkware ArniStarkware force-pushed the arni/config_manager/remove_config_manager branch from 844a53b to b401eae Compare April 5, 2026 04:36
@ArniStarkware ArniStarkware force-pushed the arni/config_manager_types/remove_rpc_infrastructure branch from be6dc48 to 80ebd9e Compare April 5, 2026 04:36
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

Artifacts upload workflows:

@ArniStarkware ArniStarkware force-pushed the arni/config_manager_types/remove_rpc_infrastructure branch from 80ebd9e to 57ed974 Compare April 5, 2026 06:27
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 57ed974. Configure here.

use apollo_state_sync_config::config::StateSyncDynamicConfig;
use async_trait::async_trait;
use serde::{Deserialize, Serialize};
use strum::{AsRefStr, EnumDiscriminants, EnumIter, IntoStaticStr, VariantNames};
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orphaned module config_manager_types is now dead code

Low Severity

The removal of ConfigManagerResponse (which was the only consumer of ConfigManagerResult) leaves the entire config_manager_types sub-module as dead code. The file config_manager_types.rs only defines pub type ConfigManagerResult<T> = Result<T, ConfigManagerError>, which is no longer referenced anywhere in the codebase. This module and its re-export in lib.rs could have been cleaned up as part of this deprecation removal.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 57ed974. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants