apollo_config_manager,apollo_node: remove ConfigManager#13644
Open
ArniStarkware wants to merge 1 commit intoarni/config_manager/remove_client_from_runnerfrom
Open
apollo_config_manager,apollo_node: remove ConfigManager#13644ArniStarkware wants to merge 1 commit intoarni/config_manager/remove_client_from_runnerfrom
ArniStarkware wants to merge 1 commit intoarni/config_manager/remove_client_from_runnerfrom
Conversation
|
This change is |
This was referenced Apr 2, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 2, 2026
ArniStarkware
force-pushed
the
arni/config_manager/remove_client_from_runner
branch
from
82fbdbd to
251ce2d
Compare
ArniStarkware
force-pushed
the
arni/config_manager/remove_config_manager
branch
from
aaf8c3f to
3ce9c16
Compare
ArniStarkware
force-pushed
the
arni/config_manager/remove_client_from_runner
branch
from
251ce2d to
c8c1f2a
Compare
ArniStarkware
force-pushed
the
arni/config_manager/remove_config_manager
branch
from
3ce9c16 to
b7855ff
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
ArniStarkware
commented
Apr 2, 2026
Contributor
Author
ArniStarkware
left a comment
ArniStarkware
left a comment
There was a problem hiding this comment.
@ArniStarkware made 1 comment and resolved 1 discussion.
Reviewable status: 0 of 6 files reviewed, all discussions resolved.
ArniStarkware
force-pushed
the
arni/config_manager/remove_client_from_runner
branch
from
c8c1f2a to
855e877
Compare
ArniStarkware
force-pushed
the
arni/config_manager/remove_config_manager
branch
2 times, most recently
from
84565df to
844a53b
Compare
ArniStarkware
force-pushed
the
arni/config_manager/remove_config_manager
branch
from
844a53b to
b401eae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Moderate risk because it removes the
ConfigManagerrequest/response server and its tests, which could break any remaining callers expecting the old RPC-style dynamic-config API. Runtime behavior shifts to watch-channel distribution only, so integration points around config updates and server wiring need verification.Overview
Removes the
ConfigManagercomponent (and its local server/communication layer) fromapollo_config_manager, leaving onlyConfigManagerRunnerto watch config files and publishNodeDynamicConfigupdates via a channel.Updates
apollo_nodewiring to stop constructing/hostingConfigManagerand to drop the local config-manager server task, while still initializingConfigManagerRunnerand the shared channel client for other components to read dynamic config.Reviewed by Cursor Bugbot for commit b401eae. Bugbot is set up for automated code reviews on this repo. Configure here.